Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component-store): initialization + updater/setState #2528

Merged
merged 3 commits into from
May 21, 2020
Merged

feat(component-store): initialization + updater/setState #2528

merged 3 commits into from
May 21, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Initial implementation of ComponentStore - adding the initialization and state updates via setState and updater.

Detailed overview of this PR can be watched here: https://www.youtube.com/watch?v=-hp72aA0wBw
馃榿

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 16, 2020 •
edited

Preview docs changes for a196f74 at https://previews.ngrx.io/pr2528-a196f74/

brandonroberts
brandonroberts approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timdeschryver
timdeschryver reviewed May 21, 2020
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM, just a question 馃憤

modules/component-store/src/component-store.ts Show resolved Hide resolved
modules/component-store/src/component-store.ts Show resolved Hide resolved
projects/ngrx.io/content/guide/component-store/index.md Outdated Show resolved Hide resolved
@alex-okrushko @timdeschryver
Update projects/ngrx.io/content/guide/component-store/index.md
a196f74 
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
@brandonroberts brandonroberts merged commit 3545df2 into ngrx:master May 21, 2020
BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 5, 2020
@alex-okrushko @BioPhoton
feat(component-store): initialization + updater/setState (ngrx#2528)
7f262f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
Project: Component Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-okrushko @ngrxbot @brandonroberts @timdeschryver