Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router-store): add selectParamFromRouterState selector #2771

Merged
merged 1 commit into from Dec 28, 2020
Merged

feat(router-store): add selectParamFromRouterState selector #2771

merged 1 commit into from Dec 28, 2020

Conversation

markostanimirovic
Copy link
Member

@markostanimirovic markostanimirovic commented Nov 2, 2020 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2758

What is the new behavior?

selectParamFromRouterState selector is added to router selectors.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 2, 2020 •
edited

Preview docs changes for 2c47d70 at https://previews.ngrx.io/pr2771-2c47d70a/

timdeschryver
timdeschryver reviewed Nov 11, 2020
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is still a draft, this looks good to me.
Let's wait on #2764 first, and then we can revisit this PR.

@alex-okrushko
Copy link
Member

Would love to get this one in soon-ish. It was raised as an issue during my recent NgRx workshop within Google.

@markostanimirovic let's discuss it :)

@markostanimirovic markostanimirovic marked this pull request as ready for review December 9, 2020 20:47
@markostanimirovic
Copy link
Member Author

@alex-okrushko @timdeschryver

It's now ready for review :)

@brandonroberts
Copy link
Member

Changes LGTM, the only thing I'm considering is renaming to selectParamFromRouterState, as RouterTree is not some people have a current association with

@markostanimirovic markostanimirovic changed the title feat(router-store): add selectParamFromRouterTree selector feat(router-store): add selectParamFromRouterState selector Dec 11, 2020
@markostanimirovic
Copy link
Member Author

@brandonroberts done

@brandonroberts brandonroberts merged commit 3a1f359 into ngrx:master Dec 28, 2020
brandonroberts added a commit that referenced this pull request Dec 28, 2020
@brandonroberts
Revert "feat(router-store): add selectParamFromRouterState selector (#…
20918c3 
…2771)"

This reverts commit 3a1f359.
@brandonroberts brandonroberts mentioned this pull request Dec 28, 2020
Merged
brandonroberts added a commit that referenced this pull request Dec 29, 2020
@brandonroberts
Revert "feat(router-store): add selectParamFromRouterState selector (#…
8d4e8cc 
…2771)" (#2845)

This reverts commit 3a1f359.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

@alex-okrushko alex-okrushko Awaiting requested review from alex-okrushko

Assignees
No one assigned
Labels
Google Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router Store: Add selector to retrieve param from anywhere in route tree
5 participants
@markostanimirovic @ngrxbot @alex-okrushko @brandonroberts @timdeschryver