Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): add loadWithQuery method #3717

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Conversation

CoranH
Copy link
Contributor

@CoranH CoranH commented Dec 17, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

This adds the functionality requested in issue #3088

Closes #3088

What is the new behavior?

Functionality from getWithQuery and load have been combined to form loadWithQuery, querying a collection with a payload/parameters, and replacing entire local cached collection.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Combine the functionality of getWithQuery and load, to query a collection and replace entire local cached collection.

resolves ngrx#3088
@netlify
Copy link

netlify bot commented Dec 17, 2022

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 84cdba2
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63b824d67921dd00082b9712

@timdeschryver timdeschryver merged commit 06b97bf into ngrx:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants