feat(data): Add HttpOptions to EntityActionOptions (#3663)

[cam-m]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Angular HttpParams and HttpHeaders cannot be passed from EntityCollectionDataService to underlying Data Service requests.

Closes #3663

What is the new behavior?

Http Params and HttpHeaders can be passed from EntityCollectionDataService to underlying Data Service requests.

Does this PR introduce a breaking change?

[] Yes
[x] No

MethodgetWithQuery(queryParams) can be refactored in a future change to remove the queryParams arg if desired. It is made redundant by the new httpOptions arg.

Other information

[netlify]

✅ Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	a6aa56f
🔍 Latest deploy log	https://app.netlify.com/sites/ngrx-io/deploys/63da591b28269c00081fd022
😎 Deploy Preview	https://deploy-preview-3664--ngrx-io.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[cam-m]

This is my first ever pull request so please let me know if I've stuffed anything up :)

[brandonroberts]

As this would be a breaking change, it would have to wait until the next major release. Also, does this PR #3717 achieve the same result?

[cam-m]

As this would be a breaking change, it would have to wait until the next major release. Also, does this PR #3717 achieve the same result?

No, and I was able to work around #3717 using the clearCache method.

This PR provides more general capability - by adding httpoptions to entity actions users can pass query params to any http requests flowing from entity actions - I raised this so I could pass params to a delete request.

I considered doing it as a non-breaking change, but I think the api would be less coherent that way. If you think users would be taking advantage of the current options parameter then perhaps I should re-do as non breaking...?

[cam-m]

Also if I'm not mistaken, this PR would solve #3717 by allowing the user to pass query params to the load action.

[brandonroberts]

If there is an option to do a non-breaking change in the short term that would be preferable. We can deprecate the current usage and do a breaking change in the next major if necessary.

[cam-m]

As this would be a breaking change, it would have to wait until the next major release. Also, does this PR #3717 achieve the same result?

Hey @brandonroberts, just FYI this now a non-breaking change.

[brandonroberts]

Thanks @cam-m!

[e-oz]

It is a breaking change.
In 15.2.1 call execute('POST', urlWithParams, requestData, {observe: 'response'}) returns HttpResponse object (because of observe: 'response'), in 15.3 the same code returns just response body.

[timdeschryver]

Do you want to create a Pull Request for this @e-oz ?

[e-oz]

Pull Request to change what exactly? I don't mind :)

[cam-m]

You're right @e-oz , I missed the case of user's adding http request options other than headers and params.

I'm happy to submit a PR to address this.

[brandonroberts]

@cam-m that would be great thanks

[cam-m]

FYI I've not forgotten about this, have had trouble getting the unit tests to run on my win machine - switched to a mac and should have a PR in today.