Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(effects): make createEffect work with TS 5.3 #4296

Merged
merged 1 commit into from Apr 11, 2024

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4275

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit ab16a14
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/66179ac000aeab000865e671

@brandonroberts brandonroberts merged commit 19c1f11 into main Apr 11, 2024
5 checks passed
@brandonroberts brandonroberts deleted the fix/createEffect-5.3 branch April 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/effects/src/effect_creator.d.ts:12:43 - error TS2313: Type parameter 'OT' has a circular constraint.
3 participants