-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type parameter 'OT' has a circular constraint. createEffect typing broken in TS 5.4 #216
Comments
The latest version of Angular require greater than 5.3 : The Angular Compiler requires TypeScript >=5.4.0 and <5.5.0 but 5.3.3 was found instead. I hope it will not be too long to have a new release with the fix. Thanks in advance! |
@marcpearson do you need the fix in mini-rx-store or signal-store? I am thinking to release a fix before the @mini-rx/common refactor (which still needs some time). |
Signal-store. All my projects will be migrate to signal-store anyway |
@marcpearson I am thinking to publish signal store v3 alpha with just the TS fix for Angular 17+ |
Hey @marcpearson , We just released @mini-rx/signal-store 3.0.0-alpha.1 with the TypeScript fix. please let us know if the issue is solved for you. Here it seems to work. |
BREAKING CHANGE: signal store requires now Angular 17 and @mini-rx/common 2 #216
With the 3.0.0-alpha.1 version, everything seems good for me too. Merci beaucoup ! |
Angular 17.3
TS 5.4.5
The same issue appears in NgRx/Effects: ngrx/platform#4275
createEffect in MiniRx is heavily inspired by NgRx...
We can apply the same fix as the NgRx team.
In the meanwhile it is possible to downgrade to TS 5.3.3 and the issue is gone.
This libs have to be fixed:
There is a refactor of mini-rx-store ongoing (#209) to use also @mini-rx/common. The refactor of mini-rx-store will be released as a new major version (v6). I suggest to release the TypeScript fix also as part of v6. In that case the fix has to be applied only in @mini-rx/common.
The text was updated successfully, but these errors were encountered: