Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type parameter 'OT' has a circular constraint. createEffect typing broken in TS 5.4 #216

Open
spierala opened this issue Apr 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@spierala
Copy link
Owner

spierala commented Apr 17, 2024

image

Angular 17.3
TS 5.4.5

The same issue appears in NgRx/Effects: ngrx/platform#4275
createEffect in MiniRx is heavily inspired by NgRx...

We can apply the same fix as the NgRx team.

In the meanwhile it is possible to downgrade to TS 5.3.3 and the issue is gone.

This libs have to be fixed:

  • mini-rx-store
  • @mini-rx/common

There is a refactor of mini-rx-store ongoing (#209) to use also @mini-rx/common. The refactor of mini-rx-store will be released as a new major version (v6). I suggest to release the TypeScript fix also as part of v6. In that case the fix has to be applied only in @mini-rx/common.

@spierala spierala added the bug Something isn't working label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant