Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

fix(devtools): Fixed AOT bug when providing devtools config options #52

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

brandonroberts
Copy link
Member

Also exposed the configuration options to the instrumentOnlyWithExtension method
Docs also updated to reflect usage of maxAge with extension

Closes #48, #51

Also exposed the configuration options to the instrumentOnlyWithExtension method
@born2net
Copy link

tx for the fix, so do we use it like before or there is new syntax?

@brandonroberts
Copy link
Member Author

@born2net no new syntax, you can use it the same way as before.

@born2net
Copy link

great tx

@MikeRyanDev MikeRyanDev merged commit d21ab15 into master Jan 19, 2017
@MikeRyanDev MikeRyanDev deleted the fix-devtools-config branch January 19, 2017 15:05
@MikeRyanDev
Copy link
Member

Published as v3.2.3

@IT-Ideas
Copy link

Hello!

It seems the same issue occurs with @ngrx/store-log-monitor as
StoreDevtoolsModule.instrumentStore({ monitor: useLogMonitor({ visible: true, position: 'right' }) }),
in the imports of the app module generates the same kind of error.

Could it be?

Thx

@brandonroberts
Copy link
Member Author

brandonroberts commented Jan 19, 2017

@IT-Ideas in order to use @ngrx/store-log-monitor you need to provide a function that returns the config

export function instrumentOptions() {
  return {
    monitor: useLogMonitor({ visible: true, position: 'right' })
  };
}

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    FormsModule,
    HttpModule,
    StoreDevtoolsModule.instrumentStore(instrumentOptions)
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule {}

@IT-Ideas
Copy link

IT-Ideas commented Jan 19, 2017

@brandonroberts Thank you, it works!

I created Pull request in @ngrx/store-log-monitor with the readme.md updated accordingly.

@born2net
Copy link

born2net commented Jan 19, 2017

Where is the definition of: useLogMonitor({ visible: true, position: 'right' })

Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/Angular-kitchen-sink
Regards,

Sean

@IT-Ideas
Copy link

IT-Ideas commented Jan 19, 2017

@born2net right here

@born2net
Copy link

tx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants