Skip to content
This repository has been archived by the owner on Jan 10, 2018. It is now read-only.

Add operator select path doesn't seem to be correct #253

Closed
alexjoverm opened this issue Oct 14, 2016 · 3 comments
Closed

Add operator select path doesn't seem to be correct #253

alexjoverm opened this issue Oct 14, 2016 · 3 comments

Comments

@alexjoverm
Copy link

Version: 1.2.0

The following path is not working:

import '@ngrx/core/add/operator/select'

I'm getting an error Property 'select' does not exist on type 'Observable'. However, it works with src:

import '@ngrx/core/src/add/operator/select'

As I understand it, it should work. You can even see it in the example app repo being used. I saw #218, not sure if it only applies to SystemJS (I'm using webpack), but definitely haven't seen any release or bundles directory generated after being the package installed, which is what rollout.js is suppose to generate.

Is something broken? Or I could be missing something?

@awerlang
Copy link

No need to add the select operator, it's already on the Store prototype.

@alexjoverm
Copy link
Author

True.

In that case, I'd suggest to update the example app. For me it is the best practical docs I found for ngrx/store, but the way the selectors are made there is not the best one, since it is not using Angular DI, thus no access to the store itself.

For example, using a service like it is done in #239. @awerlang do you agree? If so I could open a PR when I find some time

@robwormald
Copy link
Contributor

Please check this against NgRx v4, and if it’s still an issue, please reopen on https://github.com/ngrx/platform. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants