Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr-plugin): trigger ngOnDestroy for all components in app tree #1192

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1190

What is the new behavior?

Trigger ngOnDestroy for all components before destroy AppModule for avoid memory leak

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@arturovt arturovt merged commit 84ae41d into master Aug 2, 2019
@arturovt arturovt deleted the hmr/memory-leak branch August 2, 2019 12:13
@markwhitfeld markwhitfeld added this to the 3.5.x milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants