Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): improved typings for @Select decorator #1453

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue: #875

What is the new behavior?

Correct type checking for selector functions

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work.
Is there anything we need to be aware of regarding the version of TS to support this?
Also, could you add mention of this improvement in the announcement article within this PR.

@splincode splincode merged commit 5a4a6e9 into master Nov 23, 2019
@splincode splincode deleted the feat/selector branch December 1, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants