Migrate appveyor build to MySql 8 #3450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ | |||
| <NhNetCoreApp>false</NhNetCoreApp> | |||
| <NhNetCoreApp Condition="$(TargetFramework.StartsWith('netcoreapp'))">true</NhNetCoreApp> | |||
| <DefineConstants Condition="$(NhNetCoreApp) AND $(NhVbNet) == ''" >NETCOREAPP2_0_OR_GREATER;$(DefineConstants)</DefineConstants> | |||
| <WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors> | |||
There was a problem hiding this comment.
We can no more compile the 5.3.x branch without downgrading from errors these warnings back to warnings.
There was a problem hiding this comment.
Just tested GHA build on my 5.3.x branch - it builds without any issues:
https://github.com/bahusoid/nhibernate-core/actions/runs/7003210288/job/19048468922
This comment was marked as outdated.
This comment was marked as outdated.
Yeah seems we don't need it for 5.3.x: VS 2017 image is used on AppVeyour on 5.3.x branch and MySql 5.7 still there. We need it for 5.4.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #3447 .
Or maybe not: on that branch, MySql appveyor failures are allowed. But without doing that, the build would entirely fail instead of failing just for a few tests.