-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Editor will not install with React v17 #1248
Comments
@live951 I'll check this soon and see if the wrapper can update the peer-dependent version to React 17. |
@seonim-ryu any update on this? React 17 is compatible with React 16 so a simple version bump will do the job. |
ping, any update in this? Highly appreciate if this will be looked at soon , as it basically block the upgrade to React 17 for the whole app. |
Hi, I'm running into the same problem. Any news about this? |
Now React Editor V3.0 will not install with React v16. |
I created a workaround for me. I created a fork and a branch only containing the react-editor: https://github.com/bruegmann/tui.editor/tree/lgk--react-editor-only. In the "peerDependencies": {
"react": "^16.0.0 || ^17.0.0"
}, That's how I use this solution:
It would be awesome if this change could come to the official package. |
I am coming from nhn/toast-ui.react-image-editor#38 |
Making some progress. I see that the master branch is already updated to react 17. I was trying to refernce the github masterbranch directly in my package.json like so npm install "https://github.com/nhn/tui.image-editor.git\#master" --save leaves my package.json like this. "dependencies": { and I trouble making this import work import ImageEditor from '@toast-ui/react-image-editor'; any help appriciated. |
Describe the bug
NPM gives an 'unable to resolve dependency tree' error when attempting to install the react-editor in a project that is using React v17.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The react-editor should install unless there is something specific to React v17 that makes that not possible until fixed.
The text was updated successfully, but these errors were encountered: