Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to continuous integration #47

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add linting to continuous integration #47

merged 3 commits into from
Mar 7, 2024

Conversation

matt-dray
Copy link
Collaborator

Close #8. Note that:

  • this is vanilla linting with {lintr}, but I've added a .lintr file where we can set or override defaults as needed
  • I've deactivated the object-usage linter in the .lintr file because it gave a false positive for a function name that's actually part of the package
  • I've fixed all the lint failures as far as I can (and kept these in line with the tidyverse style guide if needed), though some are still outstanding:
    • we have an argument called F (fails the object-name and T-and-F linters)
    • many test files have commented-out code awaiting some input error handling (see Add function input checks #28)

@matt-dray matt-dray added this to the v0.1 milestone Feb 23, 2024
@matt-dray matt-dray self-assigned this Feb 23, 2024
Copy link
Collaborator

@ThomUK ThomUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Sorry for the delayed review. Feel free to merge and if there are any revisions we can mop them up separately...

@matt-dray matt-dray merged commit defb426 into main Mar 7, 2024
9 of 10 checks passed
@matt-dray matt-dray deleted the 8-lint-action branch March 7, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up CI/CD elements with GitHub actions
2 participants