Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid design / clearing wrapper #797

Closed
frobernik opened this issue Dec 1, 2021 · 2 comments
Closed

Fluid design / clearing wrapper #797

frobernik opened this issue Dec 1, 2021 · 2 comments
Labels
awaiting triage Needs triaging by team

Comments

@frobernik
Copy link

Bug Report

What is the issue?

We've built a fluid design for one of our pages but theres an issue where one of the panels isn't being wrapped around by the 'nhsuk-main-wrapper' container div.

What steps are required to reproduce the issue?

Build a page with a fluid layout or make a panel/div with float:left or float:right and with no clearing CSS.

What was the environment where this issue occurred?

  • Device: Macbook Pro 15
  • Operating System: macOS Monteray 12.0.1
  • Browser: Google Chrome
  • Browser version: 96.0.4664.55 (Official Build) (x86_64)

Is there anything else you think would be useful in recreating the issue?

grab
Above is an example of what we're seeing

@henocookie henocookie added the awaiting triage Needs triaging by team label Dec 1, 2021
@henocookie
Copy link
Contributor

henocookie commented Dec 2, 2021

@davidhunter08 thinks that applying the utility class nhsuk-u-clear to the containing div (panel) might solve the issue: https://github.com/nhsuk/nhsuk-frontend/blob/master/packages/core/utilities/_clearfix.scss

@frobernik could you try this and share if it solves the issue?

@frobernik
Copy link
Author

@davidhunter08 thinks that applying the utility class nhsuk-u-clear to the containing div (panel) might solve the issue: https://github.com/nhsuk/nhsuk-frontend/blob/master/packages/core/utilities/_clearfix.scss

@frobernik could you try this and share if it solves the issue?

Yes worked thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Needs triaging by team
Projects
None yet
Development

No branches or pull requests

2 participants