Skip to content
This repository has been archived by the owner on Feb 26, 2018. It is now read-only.

Check for availability of ga in script #263

Open
st3v3nhunt opened this issue Nov 1, 2017 · 0 comments
Open

Check for availability of ga in script #263

st3v3nhunt opened this issue Nov 1, 2017 · 0 comments

Comments

@st3v3nhunt
Copy link
Contributor

In customga.js it is assumed ga is available as a global function. This is only the case when Google Analytics has been loaded. Currently there is a check in the view that includes the JS. Ideally the JS would do the check itself to prevent it being run in an environment where ga should be available but for whatever reason isn't.

This would also allow all of the customXX.js files to be combined into a single one which could then be minified and hashed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant