Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nidcpower and nifgen have incorrect data type for Import/ExportAttributeConfigurationBuffer #694

Closed
bkeryan opened this issue Aug 7, 2022 · 1 comment

Comments

@bkeryan
Copy link
Contributor

bkeryan commented Aug 7, 2022

In the MI ImportAttributeConfigurationBuffer and ExportAttributeConfigurationBuffer functions, the configuration parameter is an array of bytes. The bytes contain a UTF-8 JSON string, but the API documentation doesn't document this, so it's appropriate for grpc-device to treat this parameter as an array of bytes.

nidcpower.proto and nifgen.proto incorrectly represent this parameter as repeated fixed64 configuration.

nidmm.proto, nifake.proto, and niscope.proto correctly represent this parameter as bytes configuration.

AB#2108035

@astarche astarche added bug Something isn't working and removed bug Something isn't working labels Aug 11, 2022
@reckenro
Copy link
Collaborator

Both NI-DCPower and NI-FGEN .proto files updated so those arguments are now bytes configuration.

NI-DCPower ImportAttributeConfigurationBufferRequest and ExportAttributeConfigurationBufferResponse

NI-FGEN ImportAttributeConfigurationBufferRequest and ExportAttributeConfigurationBufferResponse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants