Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and refactor tests #32

Closed
lknix opened this issue May 12, 2018 · 2 comments
Closed

Update and refactor tests #32

lknix opened this issue May 12, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lknix
Copy link
Contributor

lknix commented May 12, 2018

Tests should be testing a single unit (function). Currently we don't test all functions directly since some of them are tested through other functions. This doesn't follow the best practices because it's misleading when tests start to fail and it leaves out edge cases. Ideally, tests should:

  1. Every test should test a single unit.
  2. Every test should set up the required contract state directly prior to testing.
  3. Every unit should be fully covered.
@xpepermint
Copy link
Member

  1. Refactor variables from var to let/const.

@xpepermint xpepermint added the enhancement New feature or request label May 16, 2018
@xpepermint
Copy link
Member

Closing for now. Feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants