Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Play Audio While Paused" code plays audio even if audio is muted #12

Open
NicholasMoser opened this issue Jul 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@NicholasMoser
Copy link
Owner

It is possible to mute audio during the game:

image

Play Audio While Paused will play the audio at full volume while paused even if audio is muted. Ideally, this code will check if audio is muted before it plays while paused.

@NicholasMoser
Copy link
Owner Author

NicholasMoser commented Jul 31, 2020

Upon further investigation, it was found that this only occurs if the Play Audio While Paused code is modified.
GNTool uses the instruction 3860FFFF (li r3, 0xFFFF) for this code. In this case, the issue occurred because the instruction was modified to 38600FFF (li r3, 0x0FFF). The 0xFFFF was modified to 0x0FFF to make the music softer when the game is paused. This has the side effect of always playing the music when paused, even if music is turned off.

Currently not sure the best way to handle this, or if I even want to add the ability to modify the volume part of the code in GNTool.

@NicholasMoser NicholasMoser added the enhancement New feature or request label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant