Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2 support #39

Open
nicholastay opened this issue Nov 16, 2021 · 0 comments
Open

API v2 support #39

nicholastay opened this issue Nov 16, 2021 · 0 comments
Assignees

Comments

@nicholastay
Copy link
Owner

nicholastay commented Nov 16, 2021

API v2 support should be added into this library. - https://osu.ppy.sh/docs/index.html

For now, I reckon we shouldn't implement undocumented endpoints, as well as endpoints whose responses aren't finalised yet. It should probably be a mode to use v2, so that the two can even be used in tandem via two instances of nodesu if desired.

I'm not sure about the OAuth endpoints that requires users - will this be useful, how should we expose this to a library user (e.g. allowing access token to be passed in per call), or just simply not support this and remain a public API wrapper only (i.e. 'public' scope endpoints only implemented). Input from current library users about this would be appreciated.

Chat bots will probably be outside the scope of this project, though.

@nicholastay nicholastay self-assigned this Nov 16, 2021
@nicholastay nicholastay pinned this issue Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant