Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PersistentCopy(). #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove PersistentCopy(). #230

wants to merge 1 commit into from

Commits on Jul 6, 2018

  1. Remove PersistentCopy(). 

    First, we don't really need a shared_ptr from PersistentCopy(), since
we're not sharing it with anyone yet.
But then, we don't really need a pointer at all and we could just return
by value and let call-sites move the value to the heap themselves if
they need it there.
At this point, the function body is trivial, so we don't really need
the function.
    @gin-ahirsch
    gin-ahirsch committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    07eb073 View commit details
    Browse the repository at this point in the history