Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a globalOptions configuration property to setup custom rules and checks #114

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Conversation

dwightjack
Copy link
Contributor

This PR adds the ability to use the configureAxe function to setup custom checks and rules by adding a globalOptions property whose value will be passed to axe.configure.

It also updates the report log by checking for helpUrl before outputting the relative lines because custom rules might not have a help URL.

Reference: #112

@NickColley If you think this solution is fine, I will submit a PR to update the TypeScript definition as well.

@NickColley
Copy link
Owner

NickColley commented Jul 13, 2020

This is looking good thank you very much.

@kennygrubb do you have any thoughts on this proposal?

@kennygrubb
Copy link

Looks good to me. Thank you!

@NickColley
Copy link
Owner

Great I'll try and get this merged and released soon later today.

@dwightjack
Copy link
Contributor Author

@NickColley @kennygrubb Just for reference: I submitted a PR to update the @types/jest-axe package as well: DefinitelyTyped/DefinitelyTyped#46122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants