New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Ember.copy #123
Conversation
I haven’t dug deeply, but I believe CI is failing here due to Ember 2.4 not having Ember.assign. There is a polyfill you can add as a dep though... |
@rwjblue how do you feel about dropping 2.4 and bumping the major? It's so old at this point that I think that'd be better than adding more code |
Yep, seems totally fine to me also. I’d go all the way to 2.18 as minimum I think... |
Not sure if I made a mistake or this is just a CI failure... |
|
Ok we in business! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the upkeep effort @nlfurniss! 😄
@rwjblue, would you take the reins on ushering this in? I've been away from the project for so long now, I hardly feel in the right to do so. Do you have all the permissions you need?
I just merged #125 which handled the ember-try things here, would you mind rebasing (which will drop out the |
Rebased and ready to go :-) |
Thank you @nlfurniss! |
ember-prefetch 3.0.1 published 🎉 |
Since this isn't using
Ember.copy
to copy deeply, this should be fine.