Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Ember.copy #123

Merged
merged 1 commit into from Jan 16, 2019
Merged

Remove deprecated Ember.copy #123

merged 1 commit into from Jan 16, 2019

Conversation

nlfurniss
Copy link
Contributor

Since this isn't using Ember.copy to copy deeply, this should be fine.

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 11, 2019

I haven’t dug deeply, but I believe CI is failing here due to Ember 2.4 not having Ember.assign. There is a polyfill you can add as a dep though...

@nlfurniss
Copy link
Contributor Author

@rwjblue how do you feel about dropping 2.4 and bumping the major? It's so old at this point that I think that'd be better than adding more code

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 11, 2019

Yep, seems totally fine to me also. I’d go all the way to 2.18 as minimum I think...

@nlfurniss
Copy link
Contributor Author

Not sure if I made a mistake or this is just a CI failure...

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 11, 2019

ember-lts-2.18 isn't in config/ember-try.js (thats what the error is saying). When you add it, could you also delete 2.4/2.8?

@nlfurniss
Copy link
Contributor Author

Ok we in business!

Copy link
Owner

@nickiaconis nickiaconis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upkeep effort @nlfurniss! 😄

@rwjblue, would you take the reins on ushering this in? I've been away from the project for so long now, I hardly feel in the right to do so. Do you have all the permissions you need?

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 16, 2019

I just merged #125 which handled the ember-try things here, would you mind rebasing (which will drop out the .travis.yml and config/ember-try.js changes)?

@nlfurniss
Copy link
Contributor Author

Rebased and ready to go :-)

@rwjblue rwjblue merged commit e1964d0 into nickiaconis:master Jan 16, 2019
@rwjblue
Copy link
Collaborator

rwjblue commented Jan 16, 2019

Thank you @nlfurniss!

@nlfurniss nlfurniss deleted the no-ember-copy branch January 16, 2019 18:24
@rwjblue
Copy link
Collaborator

rwjblue commented Jan 16, 2019

ember-prefetch 3.0.1 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants