Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: warn user about writing ageEnsemble data in paleoData #34

Closed
nickmckay opened this issue Feb 22, 2018 · 4 comments
Closed

R: warn user about writing ageEnsemble data in paleoData #34

nickmckay opened this issue Feb 22, 2018 · 4 comments
Assignees

Comments

@nickmckay
Copy link
Owner

writeLipd() should warn people about writing ageEnsembles that have been mapped into paleoData. This is a common procedure in GeoChronR, and thus will come up, however it can greatly increase the size of the LiPD file, and is easily and quickly replicated upon loading with geoChronR::mapAgeEnsembleToPaleoData() .

Perhaps a warning, and then a yes/no about deleting the ageEnsemble from the paleoData?

@chrismheiser
Copy link
Collaborator

@nickmckay Should this be a "yes" or "no" parameter to writeLipd or just prompt the user on a file-by-file basis? I'm sure it'll get annoying to answer a lot of prompts if you write a bunch of files at once, but I'm also not sure that there will be a ton of files with ensemble data in Paleo, in which case file-by-file prompts may not be so bad.

Thoughts?

@nickmckay
Copy link
Owner Author

nickmckay commented Mar 8, 2018 via email

@chrismheiser
Copy link
Collaborator

And if ignore.warnings were set to TRUE, then don't bother to check for ensemble data in paleo? Or remove the ensemble data from paleo and just don't write about it?

@nickmckay
Copy link
Owner Author

nickmckay commented Mar 8, 2018 via email

chrismheiser added a commit that referenced this issue Mar 12, 2018
Not done with this yet, but saving progress to work on a Python issue.
chrismheiser added a commit that referenced this issue Mar 13, 2018
- When a user attempts to writeLipd with ageEnsemble data in the
paleoData section, warn them that it will increase the file size and
give the option to remove that data before writing the file. The
ageEnsemble can be recreated next time and doesn’t need to be saved.
- Updated some docs and namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants