-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R: warn user about writing ageEnsemble data in paleoData #34
Comments
@nickmckay Should this be a "yes" or "no" parameter to writeLipd or just prompt the user on a file-by-file basis? I'm sure it'll get annoying to answer a lot of prompts if you write a bunch of files at once, but I'm also not sure that there will be a ton of files with ensemble data in Paleo, in which case file-by-file prompts may not be so bad. Thoughts? |
Hmm,
How about the default is case by case, but there's an "ignore.warnings"
option that's set to FALSE by default in writeLipd()?
…On Thu, Mar 8, 2018 at 12:38 PM, Christopher Heiser < ***@***.***> wrote:
@nickmckay <https://github.com/nickmckay> Should this be a "yes" or "no"
parameter to writeLipd or just prompt the user on a file-by-file basis? I'm
sure it'll get annoying to answer a lot of prompts if you write a bunch of
files at once, but I'm also not sure that there will be a ton of files with
ensemble data in Paleo, in which case file-by-file prompts may not be so
bad.
Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK73Z2BPx0gJ2KQ-dTbQ3OWuMZLvZvOOks5tcYi6gaJpZM4SPpTh>
.
|
And if ignore.warnings were set to TRUE, then don't bother to check for ensemble data in paleo? Or remove the ensemble data from paleo and just don't write about it? |
Write it without a warning.
…On Thu, Mar 8, 2018 at 12:48 PM, Christopher Heiser < ***@***.***> wrote:
And if ignore.warnings were set to TRUE, then don't bother to check for
ensemble data in paleo? Or remove the ensemble data from paleo and just
don't write about it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK73Z6ZmQFHNrwmu_-rfw7kjTaxnXucHks5tcYsYgaJpZM4SPpTh>
.
|
Not done with this yet, but saving progress to work on a Python issue.
- When a user attempts to writeLipd with ageEnsemble data in the paleoData section, warn them that it will increase the file size and give the option to remove that data before writing the file. The ageEnsemble can be recreated next time and doesn’t need to be saved. - Updated some docs and namespace.
writeLipd() should warn people about writing ageEnsembles that have been mapped into paleoData. This is a common procedure in GeoChronR, and thus will come up, however it can greatly increase the size of the LiPD file, and is easily and quickly replicated upon loading with geoChronR::mapAgeEnsembleToPaleoData() .
Perhaps a warning, and then a yes/no about deleting the ageEnsemble from the paleoData?
The text was updated successfully, but these errors were encountered: