Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lipd.readLipd.py needs improvement -- here's some simple things! #37

Closed
chrismheiser opened this issue Mar 12, 2018 · 1 comment
Closed

Comments

@chrismheiser
Copy link
Collaborator

@ericsteig writes:

The default for lipd.readLipdshould be to expect a filename, not open a GUI.

*The path should by default assume './'.

Details:

The default for lipd.readLipd is to open a GUI (which I would never want). Also, the GUI doesn't open on my machine. I don't care since I'll never use it!

I have a lipd file called GISP2.lpd.
If I'm already in the right directory, I should be able to read it with:

D = lipd.readLipd('GISP2.lpd')

but that doesn't work. I have to say:

D = lipd.readLipd('./GISP2.lpd')

which just is silly.

chrismheiser added a commit that referenced this issue Mar 12, 2018
Previously, to use readLipd with a file in your current working
directory you would have to call readLipd(“./file.lpd”). Now, you can
drop the prefix and call readLipd(“file.lpd”).

This will NOT work for directories, as providing an empty parameter
will trigger the GUI browse. You must use readLipd(“./”) to read the
whole current directory for files.
@chrismheiser
Copy link
Collaborator Author

I fixed the issue with the "./" You don't need it to call a file in your current working directory anymore.

We decided to keep the current use of the GUI as the fallback when the function is called with an empty "usr_path" parameter. If someone wants to open a file directly, then they can provide pass that path to the function call which circumvents the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant