Remove EOL options as we can just rely on calling next_line #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we decided we didn't need this, right?
|
oh, yeah, we should talk about this! I actually didn't get it working with the alternative implementation, where we just call So we're still relying on this little workaround for now |
|
i think this only didn't work before because on an issue in Parsers.jl but if/when that's fixed, it'd be a good change to make to simplify the code (and hopefully simplify the number of cases we have to handle when parsing transfomer data #17 and in particular simplify the code in #23) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we decided we didn't need this, right?