Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KPrototypes fit_predict fails with sample_weight #175

Closed
FGlazov opened this issue Apr 13, 2022 · 2 comments
Closed

KPrototypes fit_predict fails with sample_weight #175

FGlazov opened this issue Apr 13, 2022 · 2 comments
Labels
bug

Comments

@FGlazov
Copy link

FGlazov commented Apr 13, 2022

Expected Behavior

It should be possible to pass a sample_weight to fit_predict in KPrototypes, and to get the cluster labels from the weighted fitting.

Actual Behavior

Passing a sample_weight to fit_predict causes an exception. This is because the predict function in KProtoypes does not have a **kwargs, nor does it take a sample_weight.

Steps to Reproduce the Problem

Pass a sample_weight to fit_predict of KPrototypes, along with some data.

Specifications

  • Version: 0.12
  • Platform: Ubuntu 20.04 LTS, Python 3.8,
@FGlazov FGlazov added the bug label Apr 13, 2022
@nicodv nicodv mentioned this issue Apr 13, 2022
Merged
@nicodv
Copy link
Owner

nicodv commented Apr 13, 2022

Thanks for reporting, @FGlazov . This is fixed by #176

Until that's released, please use fit and predict sequentially.

@nicodv nicodv closed this as completed Apr 13, 2022
@nicodv
Copy link
Owner

nicodv commented Apr 14, 2022

New release with this fix: https://github.com/nicodv/kmodes/releases/tag/0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicodv @FGlazov