Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand selection to region with nearest possible refactoring #48

Closed
kbysiec opened this issue Nov 14, 2019 · 2 comments
Closed

Expand selection to region with nearest possible refactoring #48

kbysiec opened this issue Nov 14, 2019 · 2 comments
Labels
✨ Feature New refactoring or feature

Comments

@kbysiec
Copy link

kbysiec commented Nov 14, 2019

Is this request related to a problem? Please describe.

Trying to refactor there is a necessity to select or put the cursor on the exact place to see the available refactorings. I know that it is a default for VSC built-in refactoring but it is problematic/ irritating.

Describe the solution you'd like

It would be perfect if there will be a command which will combine two steps:

  1. Expand selection to the region with nearest possible refactoring if there is not currently already done
  2. Show available refactorings for the selected region/code

The feature I mean is implemented in that way in another extension: Intelli Refactor

Additional context

Thank you for great extension!

@kbysiec kbysiec added the ✨ Feature New refactoring or feature label Nov 14, 2019
@kbysiec
Copy link
Author

kbysiec commented Nov 14, 2019

I have just noticed I can use the feature from the extension I mentioned. After selection, it shows all available refactorings, from abracadabra as well.

@kbysiec kbysiec closed this as completed Nov 14, 2019
@nicoespeon
Copy link
Owner

Hi @kbysiec and thanks for the kind words 👋

Indeed, Abracadabra is a bit more flexible than VS Code built-in refactorings: it will work as long as your cursor is inside a code that can be refactor.

I didn't knew about Intelli Refactor, thanks for mentioning. Thus, I'm not sure if the problem was solved because it's Abracadabra default behavior or if it combines well with this other extension. Anyway, I'm glad it works as you expect now! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature New refactoring or feature
Projects
None yet
Development

No branches or pull requests

2 participants