Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to change default username and realm #1098

Merged
merged 1 commit into from
May 28, 2017
Merged

add option to change default username and realm #1098

merged 1 commit into from
May 28, 2017

Conversation

micmejia
Copy link
Contributor

Description

With this PR, glances will be able to read password from <any_user>.pwd file. Currently it only works for glances.pwd.

This also changes the realm displayed during authentication from private to glances as default.

Sample usage:
glances -w --password --username-default=<any_user> --realm=<any_realm>

Resume

  • Bug fix: yes
  • New feature: yes
  • Fixed tickets: comma-separated list of tickets fixed by the PR, if any

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 37.811% when pulling f60c8b7 on micmejia:feature/change-def-username-realm into 903074a on nicolargo:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 37.811% when pulling f60c8b7 on micmejia:feature/change-def-username-realm into 903074a on nicolargo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 37.811% when pulling f60c8b7 on micmejia:feature/change-def-username-realm into 903074a on nicolargo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 37.811% when pulling f60c8b7 on micmejia:feature/change-def-username-realm into 903074a on nicolargo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 37.811% when pulling f60c8b7 on micmejia:feature/change-def-username-realm into 903074a on nicolargo:master.

@nicolargo nicolargo self-assigned this May 26, 2017
@nicolargo nicolargo added this to the Glances 2.11 milestone May 26, 2017
@nicolargo nicolargo merged commit 52e0cca into nicolargo:master May 28, 2017
@nicolargo nicolargo mentioned this pull request May 28, 2017
Merged
nicolargo
nicolargo reviewed May 28, 2017
View reviewed changes
Copy link
Owner

@nicolargo nicolargo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the pull request on the DEVELOP branch, not the MASTER !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolargo nicolargo nicolargo left review comments

Assignees

@nicolargo nicolargo

Labels
enhancement
Projects
None yet
Milestone
Glances 2.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@micmejia @coveralls @nicolargo