Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M.vec in fixedTTrankfactory "index out of bounds" #33

Closed
NicolasBoumal opened this issue Jan 7, 2021 · 1 comment
Closed

M.vec in fixedTTrankfactory "index out of bounds" #33

NicolasBoumal opened this issue Jan 7, 2021 · 1 comment

Comments

@NicolasBoumal
Copy link
Owner

The following code fails:

M = fixedTTrankfactory([2 2 2 2], [1 2 2 2 1]);
X = M.rand()
V = M.randvec(X)
v = M.vec(X, V) % fails

with the follow error message:

Index exceeds the number of array elements (4).
Error in fixedTTrankfactory/vec (line 277)
            ind_step = numel(Z.dU{index}); 
@michael-psenka
Copy link
Contributor

Hello Nicolas,

Thank you for raising this. There were a couple of trivial bugs involving the indexing in M.vec for fixedTTrankfactory.

I have rebased my fork and pushed an update that fixes M.vec, which now runs as intended on my machine; also, is this the best way for me to push future changes?

Best,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants