Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help is illegible in jupyter due to color #32

Closed
evelynmitchell opened this issue Oct 5, 2020 · 5 comments
Closed

Help is illegible in jupyter due to color #32

evelynmitchell opened this issue Oct 5, 2020 · 5 comments

Comments

@evelynmitchell
Copy link
Contributor

  • igel version: don't know there's no --version
  • Python version: 3.8.2
  • Operating System: Ubuntu 20.04

Description

Displayed the help, but any of the sections which used the lightest formatting were illegible.

I expected to be able to read the help.

What I Did

While trying to read the help in a jupyter notebook with a white background (the default).
!igel --help

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Suggested fix, remove the colorama until the project is more mature.

@nidhaloff
Copy link
Owner

nidhaloff commented Oct 5, 2020

@evelynmitchell Thanks for noticing this. I agree, I was already hesitating whether colorama was/is needed at this stage.

@dinhanhx: can you please undo the colorama implementation? I think it would be a lot easier for you to do it since you implemented it

@nidhaloff
Copy link
Owner

nidhaloff commented Oct 5, 2020

@evelynmitchell It's actually common that python package does not have the package --version option. I think this is a nodejs thing but I'm not sure, maybe this is common in other languages. In python, you can generally check the version by running pip list , pip freeze or pip show igel.

However, in igel, there is a version dunder variable (which is common in python), so just as a hint, when you import igel, you can print the version by running:

print(igel.__version__)

@dinhanhx
Copy link
Contributor

dinhanhx commented Oct 5, 2020

@nidhaloff Got it sir, i will remove anything related to colorama. I am sorry for not thinking of Jupiter notebook

@nidhaloff
Copy link
Owner

nidhaloff commented Oct 5, 2020

@dinhanhx No problem. I already did it now. You can make another extra check if you want to.

@evelynmitchell I added an extra version command. You can type igel version in order to get the version directly in the terminal. Furthermore, you can type igel info to get extra meta data about the package. I will close the issue, but feel free to open others if you encounter any problem ;)

@evelynmitchell
Copy link
Contributor Author

igel version: 0.2.7 looks good.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants