added support to where method and tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choyrim
reviewed
Nov 22, 2023
|
LGTM. The real pydeequ maintainers will probably have better feedback on how best to guard the where method. actually one other (hacky) approach is to see if the class of the _Check instance has a method "where" that takes a string. |
|
@choyrim, python-deequ pretty messy in the way it's integrated with Scala version. I think we should try to submit this MR and what kind of feedback they will share. What is the next step to do that. Do we need to have your formal approval or we just can go ahead and create MR in python-deequ open source repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs#158
Description of changes:
Added where method, the requirement to use it with the current setup is to make sure that the Check is represented by its child class CheckWithLastConstraintFilterable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.