Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydeequ to support additional where filters #158

Closed
andreimekk opened this issue Sep 25, 2023 · 3 comments
Closed

Pydeequ to support additional where filters #158

andreimekk opened this issue Sep 25, 2023 · 3 comments
Labels
feature request Feature request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andreimekk
Copy link

Is your feature request related to a problem? Please describe.
From what I can understand there's no implementation of CheckWithLastConstranitFilterable from Deequ in Pydeequ which makes it impossible to add (.where) method at the end of the defined check. Is there any particular reason for that or it's just part of Deequ that hasn't been implemented yet?

Describe the solution you'd like
Additional class in Pydeequ that extends Check so that we can specify additional SQL WHERE statement to apply before evaluation of the previous constraint.

@chenliu0831 chenliu0831 added feature request Feature request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 26, 2023
@chenliu0831
Copy link
Contributor

chenliu0831 commented Oct 18, 2023

It's not implemented yet - I think this was planned before #30. I do agree this seems to be a major gap that should be prioritized.

@chenliu0831
Copy link
Contributor

Will do a minor version release around EOW 12/08 - 12/11

@chenliu0831
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants