Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upload to S3 on local cache hit #66

Closed
franklin-ross opened this issue Jan 11, 2024 · 2 comments · Fixed by #76
Closed

Don't upload to S3 on local cache hit #66

franklin-ross opened this issue Jan 11, 2024 · 2 comments · Fixed by #76
Assignees

Comments

@franklin-ross
Copy link

When using S3 with save-cache: true and the local cache hits, we seem to then upload the local cache to S3 in the post-command step. That doesn't seem necessary as a local cache hit implies the same entry already exists in S3 and was previously downloaded.

image


For comparison, here's what happens when the local cache misses and we download from S3, no 10 second upload:

image

@gencer gencer self-assigned this Jan 11, 2024
@calvinbui
Copy link
Contributor

i'm taking a look

@franklin-ross
Copy link
Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants