Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message handling, debugging #39

Closed
3 tasks done
hexabits opened this issue Mar 8, 2014 · 0 comments
Closed
3 tasks done

Message handling, debugging #39

hexabits opened this issue Mar 8, 2014 · 0 comments
Assignees
Milestone

Comments

@hexabits
Copy link
Member

hexabits commented Mar 8, 2014

There's no way of knowing offhand what messages are meant for the end-user and which are truly for debugging. Many errors are a mix of qDebug(), qWarning(), qCritical(), qFatal() and actual QMessageBox classes.

Should probably explicitly call QMessageBox for messages intended for the user, and define QT_NO_DEBUG_OUTPUT and QT_NO_WARNING_OUTPUT for release builds so that those calls are optimized away during compilation.

Also, see: Debugging Techniques

It suggests defining QT_MESSAGE_PATTERN to make debug messages more useful. I misread it as being a define, when it is in fact an environment variable.

Task List

  • Remove NO_MESSAGEHANDLER. (See also: NifSkope.pro file cleanup #27)
  • Promote any qDebug() and qWarning() calls which are meant for end user to qCritical() or higher, or a QMessageBox proper.
  • Define QT_NO_DEBUG_OUTPUT (and possibly QT_NO_WARNING_OUTPUT) for release builds.

Invalid Tasks

  • Define QT_MESSAGE_PATTERN for more informative debug output. Guess this is an environment variable, NOT a define.
@hexabits hexabits added the T:task label Mar 9, 2014
@neomonkeus neomonkeus added this to the v1.1.4 milestone Mar 11, 2014
@hexabits hexabits self-assigned this Mar 12, 2014
@hexabits hexabits modified the milestones: v1.5.0, v1.1.4 May 17, 2014
@hexabits hexabits modified the milestones: v1.5.0, v2.0.0 Nov 2, 2014
@hexabits hexabits mentioned this issue Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants