Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists is illformed #395

Closed
SpaceIm opened this issue Oct 10, 2023 · 0 comments · Fixed by #396
Closed

CMakeLists is illformed #395

SpaceIm opened this issue Oct 10, 2023 · 0 comments · Fixed by #396

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 10, 2023

CMakeLists.txt of glew is illformed. cmake_minimum_required() then project() must be the first instructions in a CMakeLists (some specific instructions may be called between cmake_minimum_required() and project(), but it's an edge case).

Currently, glew CMakeLists defeats any cmake toolchain.

Moreover cmake_minimum_required has been updated in #391, but several explicit POLICIES have been kept, while it doesn't make sense anymore since bump of min CMake version automatically set these POLICIES to NEW.
It's also not clear why this bump was required. It's not because some distro provides a specific CMake version by default, that you have to bump min CMake version in a library. You bump min version depending on CMake policies you want, and CMake features you want to use, it doesn't make sense to hard fail with older CMake versions if not necessary.

If it was due to #388, well 3.5 is sufficient. 3.15 is also considered as a very good min version for CMake policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant