Remove external insulin event #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NightscoutTreatment should be agnostic, so moving the init extension into PumpHistoryStorage allows for better sepearation of concerns.
avouspierre
reviewed
Apr 15, 2024
This was referenced Apr 15, 2024
|
Merging into dev after review by @avouspierre |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#102 points out that there was the external insulin event type that was only ever used by NS.
This PR prefixes the external insulin event type with
nsto signify that is an nightscout only event type, and moves the logic for creating the NightscoutTreatment from a PumpHistoryEvent into a NightscoutTreatment initializer.Also fixes typo NigtscoutTreatment -> NightscoutTreatment