Add SMB flag and display SMBs in history. #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
|
I wonder about the creation of the variable versus event.type. Why don’t use the event.type with a new type for example .automaticBolus ? in fact same question with isexternalbolus where there is a new variable and a new type of event. What’s the interest because the risk of divergence could be a issue… |
Closed
|
Tested in alpha version with success. OK for me. My previous comment was resolved with PR #110 |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Artificial-Pancreas/iAPS#219 for #47.
Creates a new flag for
isSMBand displays SMBs similar to external insulin within the history sheet. In a follow-up PR, will cleanup the History list.