Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log external insulin retrospectively #47

Closed
bjornoleh opened this issue Apr 4, 2024 · 7 comments
Closed

Log external insulin retrospectively #47

bjornoleh opened this issue Apr 4, 2024 · 7 comments
Assignees
@Sjoerd-Bo3 @BrianWieder
Labels
enhancement New feature or request

Comments

@bjornoleh
Copy link
Contributor

Question raised in Discord:
@Sjoerd-Bo3 asked: "is it not possible in Oiaps to add insulin retrospectively? So when I injected insulin manually, and forgot to log. I could in 3.x but was it not in there before?"

@dnzxy listed these relevant PRs from iAPS:

Artificial-Pancreas/iAPS#267
Artificial-Pancreas/iAPS#271
Artificial-Pancreas/iAPS#289
and adjacent: Artificial-Pancreas/iAPS#272
@bjornoleh bjornoleh added the enhancement New feature or request label Apr 4, 2024
@BrianWieder BrianWieder self-assigned this Apr 10, 2024
This was referenced Apr 11, 2024
Merged
Merged
@dnzxy dnzxy mentioned this issue Apr 13, 2024
Open
@BrianWieder BrianWieder mentioned this issue Apr 14, 2024
Merged
@bjornoleh
Copy link
Contributor Author

@BrianWieder , is this issue closed with #80 and #93?

@BrianWieder
Copy link
Contributor

Not quite yet, Artificial-Pancreas/iAPS#272 still needs to be ported over, and Artificial-Pancreas/iAPS#314 is sort of related as well, that I wanted to port over.

@bjornoleh
Copy link
Contributor Author

Is this something that could make it to v1.0 in the next few days ☺️

Perhaps it’s not such a big rush to get these last bits ported, just checking 🙂

@Sjoerd-Bo3
Copy link
Contributor

I'm already using it from the log :)

@bjornoleh
Copy link
Contributor Author

I'm already using it from the log :)

I was referring to porting of the iAPS PRs Nr 272 and 314 mentioned above, the other changes are already merged :-)

@BrianWieder
Copy link
Contributor

Sure, will work on porting those PRs tonight. Sorry, been a hectic past week at work.

BrianWieder added a commit that referenced this issue May 1, 2024
@BrianWieder @dnzxy
Rework glucose dialog
2fe7d9e 
This ports Artificial-Pancreas/iAPS#272 into Open-iAPS.

This is part of #47

Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
@BrianWieder BrianWieder mentioned this issue May 1, 2024
Closed
BrianWieder added a commit that referenced this issue May 3, 2024
@BrianWieder @dnzxy
Rework glucose dialog
a52f2d6 
This ports Artificial-Pancreas/iAPS#272 into Open-iAPS.

This is part of #47

Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
BrianWieder added a commit that referenced this issue May 6, 2024
@BrianWieder @dnzxy
Rework glucose dialog
dddcd87 
This ports Artificial-Pancreas/iAPS#272 into Open-iAPS.

This is part of #47

Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
BrianWieder added a commit that referenced this issue May 10, 2024
@BrianWieder @dnzxy
Rework glucose dialog
8daf101 
This ports Artificial-Pancreas/iAPS#272 into Open-iAPS.

This is part of #47

Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
@bjornoleh
Copy link
Contributor Author

Closed as completed by:
#80
#93
#110
#140

Sjoerd-Bo3 pushed a commit to Sjoerd-Bo3/Trio that referenced this issue Oct 19, 2024
@dnzxy
Switch to glucose tab when saving manual glucoe nightscout#47
b1907e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sjoerd-Bo3 Sjoerd-Bo3

@BrianWieder BrianWieder

Labels
enhancement New feature or request
Projects
Trio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sjoerd-Bo3 @BrianWieder @bjornoleh