Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3 dev-b User entries duplicated for Carbs #3279

Closed
Philoul opened this issue Mar 25, 2024 · 3 comments
Closed

3.3 dev-b User entries duplicated for Carbs #3279

Philoul opened this issue Mar 25, 2024 · 3 comments

Comments

@Philoul
Copy link
Contributor

Philoul commented Mar 25, 2024

As you can see in screenshot below, user entries are duplicated, first entry recorded within dialog (with correct icon) second entry recorded within PersistentLayerImpl (In think after analysis) with wrong icon (always Treatments icon) as source:
Note that duplicated information is only for Carbs and is not for boluses...

image

I don't know the reason of this second entries within PersistentLayerImpl (but I think both could be removed in PersistentLayerImpl class because eather for a new entry or an update of an existing one, it should already be recorded with the correct icon where the action comes from (wear watch command, Carbs, Treatments, Calculator or QuickWizard dialogs, NS or SMS...)
image

@Philoul
Copy link
Contributor Author

Philoul commented Mar 25, 2024

Note, if you agree to my proposal to remove log command within insertOrUpdateCarbs, I can make a PR ;-)

@MilosKozak
Copy link
Contributor

I'd keep logging in PersistentLayerImpl only to make the logging independent to UI and other code

@Philoul
Copy link
Contributor Author

Philoul commented Mar 26, 2024

Ok, so I propose to use a dedicated icon / source for persistant layer (I suggest database icon), different than treatments icon used for Treatments Dialog in overview...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants