Separate Adjustment Factors for Logarithmic and Sigmoid #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes defaults to 0.8 for Logarithmic and 0.5 for Sigmoid
This was referenced Apr 15, 2024
bjornoleh
pushed a commit
to nightscout/Trio
that referenced
this pull request
Apr 26, 2024
Brings in nightscout/trio-oref#21 oref0 branch: separate_adjustment_factors - git version: 969586d
bjornoleh
approved these changes
Apr 28, 2024
|
Briefly tested in OiAPS, and found to work as expected. |
JeremyStorring
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue nightscout/Trio#106 by using separate variables for Adjustment Factor when using Logarithmic DynamicISF vs Sigmoid DynamicISF. Defaults AF to 0.8 for Logarithmic and 0.6 for Sigmoid.
Pairs with this PR in Open-iAPS: nightscout/Trio#114