Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate setting for Sigmoid Adjustment Factor vs Logarithmic Adjustment Factor #106

Closed
MikePlante1 opened this issue Apr 14, 2024 · 5 comments

Comments

@MikePlante1
Copy link
Contributor

I think a new setting should be added for Adjustment Factor so Logarithmic DynamicISF can default to 0.8 and Sigmoid DynamicISF can default to 0.5. This prevents new users from starting DynamicISF in Logarithmic mode with a default of 0.5 which seems to often lead to prolonged highs for many people. Also helpful for those who switch between Logarithmic and Sigmoid depending on their situation.

@MikePlante1
Copy link
Contributor Author

I started playing around with it, but am not too confident about the oref side of things. Here's all I've got so far (let me know if you want access to view it): dev...MikePlante1:Open-iAPS:separate_adjustment_factors

Screenshot 2024-04-14 at 10 10 05 AM

@MikePlante1
Copy link
Contributor Author

Opened PRs #114 and nightscout/trio-oref#21 to address this issue.

@bjornoleh
Copy link
Contributor

This looks very reasonable for both repositories, and I agree that we need this. I have only looked at the PRs superficially so far.

@MikePlante1
Copy link
Contributor Author

I’ve only loosely tested this in a simulator so far, by the way, so more thorough testing should be done before approving.

@MikePlante1
Copy link
Contributor Author

Closing this issue since nightscout/trio-oref#21 and #114 are merged into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants