Skip to content

Commit

Permalink
chore: fix build duration for HTML Reporter (#3683)
Browse files Browse the repository at this point in the history
  • Loading branch information
Vaibhav Singh authored and gravityvi committed Apr 7, 2023
1 parent 48f488f commit 4173ac0
Show file tree
Hide file tree
Showing 5 changed files with 15,554 additions and 2,418 deletions.
8 changes: 5 additions & 3 deletions lib/reporter/reporters/html.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class HtmlReporter extends BaseReporter {
this.environments[testEnv].stats.failed += failedCount;
this.environments[testEnv].stats.skipped += module.skippedCount;
this.environments[testEnv].stats.total += passedCount + failedCount + module.skippedCount;
this.environments[testEnv].stats.time += this.environments[testEnv].stats.time || module.timeMs;
this.environments[testEnv].stats.time += module.timeMs || this.environments[testEnv].stats.time;
this.environments[testEnv].metadata.platformName = this.environments[testEnv].metadata.platformName || sessionCapabilities.platformName;
this.environments[testEnv].metadata.browserName = this.environments[testEnv].metadata.browserName || sessionCapabilities.browserName;
this.environments[testEnv].metadata.browserVersion = this.environments[testEnv].metadata.browserVersion || sessionCapabilities.browserVersion;
Expand All @@ -107,12 +107,15 @@ class HtmlReporter extends BaseReporter {
}

aggregateStats() {
const startTime = new Date(this.results.startTimestamp).getTime();
const endTime = new Date(this.results.endTimestamp).getTime();

const stats = {
total: 0,
passed: 0,
failed: 0,
skipped: 0,
time: 0
time: endTime - startTime
};

for (const envName of Object.keys(this.environments)) {
Expand All @@ -122,7 +125,6 @@ class HtmlReporter extends BaseReporter {
stats.failed += env.stats.failed;
stats.skipped += env.stats.skipped;
stats.total += env.stats.total;
stats.time += env.stats.time || 0;
}

return stats;
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"dependencies": {
"@nightwatch/chai": "5.0.2",
"@nightwatch/html-reporter-template": "0.1.4",
"@nightwatch/html-reporter-template": "0.2.1",
"ansi-to-html": "0.7.2",
"assertion-error": "1.1.0",
"boxen": "5.1.2",
Expand Down
Loading

0 comments on commit 4173ac0

Please sign in to comment.