Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag_filter type to NightwatchOptions interface. #3825

Closed
garg3133 opened this issue Jul 21, 2023 · 2 comments
Closed

Add tag_filter type to NightwatchOptions interface. #3825

garg3133 opened this issue Jul 21, 2023 · 2 comments
Assignees
@Ykumar1415
Labels
good first issue

Comments

@garg3133
Copy link
Member

Description of the bug/issue

tag_filter type is missing from the NightwatchOptions interface, so we need to add it in both this project and @types/nightwatch project for backporting it in v2.6.x.

tag_filter should be added as an optional property of NightwatchOptions interface with type string | string[].

Steps to reproduce

No response

Sample test

No response

Command to run

No response

Verbose Output

No response

Nightwatch Configuration

No response

Nightwatch.js Version

3.0.1

Node Version

No response

Browser

No response

Operating System

No response

Additional Information

No response
@Ykumar1415
Copy link
Contributor

@garg3133 i want to work on this issue. can you assign this issue to me ?

@Ykumar1415 Ykumar1415 mentioned this issue Jul 21, 2023
Closed
8 tasks
@garg3133 garg3133 mentioned this issue Jul 28, 2023
Merged
8 tasks
AutomatedTester pushed a commit that referenced this issue Aug 9, 2023
@Ykumar1415
Fix : Add tag_filter type to NightwatchOptions interface. #3825 (#3830)
6e36f45
@garg3133
Copy link
Member Author

garg3133 commented Aug 11, 2023 •
edited

Fixed in #3830 and DefinitelyTyped/DefinitelyTyped#66203. Thanks, @Ykumar1415!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ykumar1415 Ykumar1415

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garg3133 @Ykumar1415