Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Add tag_filter type to NightwatchOptions interface. #3825 #3830

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

Ykumar1415
Copy link
Contributor

@Ykumar1415 Ykumar1415 commented Jul 21, 2023

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2023

CLA assistant check
All committers have signed the CLA.

@Ykumar1415
Copy link
Contributor Author

Ykumar1415 commented Jul 23, 2023

@garg3133
Screenshot from 2023-07-23 12-56-35
is it fine now ?

@garg3133
Copy link
Member

@Ykumar1415 Looks good!

@Ykumar1415 Ykumar1415 requested a review from garg3133 July 23, 2023 07:50
@garg3133
Copy link
Member

@Ykumar1415 Can you add a test in types/tests/index.test-d.ts to make sure that it works correctly (it is available as browser.options.tag_filter with correct type)?

@AutomatedTester AutomatedTester merged commit 6e36f45 into nightwatchjs:main Aug 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants