Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshots not saved into missing folders #65

Closed
jtibble opened this issue Feb 25, 2014 · 1 comment
Closed

Screenshots not saved into missing folders #65

jtibble opened this issue Feb 25, 2014 · 1 comment
Labels
enhancement

Comments

@jtibble
Copy link

jtibble commented Feb 25, 2014

When saving screenshots with the screenshots 'enabled' flag, if you specify a folder that does not exist, Nightwatch fails to create the folder. May be related to issue #55

Windows 7 x64, NW version 0.3.7
@beatfactor
Copy link
Member

this wasn't implemented, it's missing functionality.

@beatfactor beatfactor added the bug label Feb 26, 2014
sethmcl added a commit to sethmcl/nightwatch that referenced this issue Jun 20, 2014
@sethmcl
Fix for issue nightwatchjs#65: Screenshots not saved into missing fol…
38f1729 
…ders

Create directory structure if needed when saving screetshots (using mkdirp module).

Includes unit test.
@sethmcl sethmcl mentioned this issue Jun 20, 2014
Merged
sethmcl added a commit to sethmcl/nightwatch that referenced this issue Jun 24, 2014
@sethmcl
Merge branch 'nightwatchjsgh-65'
dd48ac8 
* nightwatchjsgh-65:
  Just realized `mkpath` is already a dependency, so using that instead of `mkdirp`.
  Fix for issue nightwatchjs#65: Screenshots not saved into missing folders
beatfactor added a commit that referenced this issue Jun 26, 2014
@beatfactor
Merge branch 'gh-65' of https://github.com/sethmcl/nightwatch into se…
536d461 
…thmcl-gh-65
beatfactor added a commit that referenced this issue Jun 26, 2014
@beatfactor
Merge branch 'sethmcl-gh-65'
a50a5e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beatfactor @jtibble