Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing junit report generation when folder doesn't exist. #55

Merged
merged 2 commits into from
Feb 24, 2014
Merged

fixing junit report generation when folder doesn't exist. #55

merged 2 commits into from
Feb 24, 2014

Conversation

neuhoffm
Copy link

On windows when specifying a output folder the folder structure of the tests must manually be created. This change automatically creates the folder structure as needed.

fs.js:427
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^
Error: ENOENT, no such file or directory 'C:\development\ui-tests\tests\Security\Login.xml'
    at Object.fs.openSync (fs.js:427:18)
    at Object.fs.writeFileSync (fs.js:966:15)
    at C:\development\code\Tests\node_modules\nightwatch\runner\reporters\junit.js:36:10
    at fs.js:266:14
    at Object.oncomplete (fs.js:107:15)

@beatfactor
Copy link
Member

this is already taken care of by ensureDir in run.js so I'd rather fix the implementation there instead of introducing an external dependency.

@beatfactor beatfactor merged commit 6348c4b into nightwatchjs:master Feb 24, 2014
@beatfactor
Copy link
Member

in the end I used the module you have added and dropped ensureDir altogether. thanks!

@jtibble
Copy link

jtibble commented Feb 25, 2014

I'm also having this same issue in Windows 7, even after updating with 'npm update'. Running version 0.3.6 as verified with 'npm list'

@beatfactor
Copy link
Member

try now, npm update to v0.3.7. seems to work for me on windows 7.

@jtibble
Copy link

jtibble commented Feb 25, 2014

This is fixed for me now with v0.3.7, but I'm seeing an issue with not-created-folders for screenshots as well. Is this possibly related?

-John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants