Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3693 - Nightwatch session is not getting closed in serial mode #3694

Merged
merged 7 commits into from
May 16, 2023
Merged

Fix 3693 - Nightwatch session is not getting closed in serial mode #3694

merged 7 commits into from
May 16, 2023

Conversation

harshit-bs
Copy link
Member

No description provided.

@swrdfish swrdfish marked this pull request as ready for review May 5, 2023 15:18
vaibhavsingh97
vaibhavsingh97 reviewed May 6, 2023
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sugggested some refactoring changes. I will review them more thoroughly tomorrow.

lib/runner/test-runners/default.js Show resolved Hide resolved
lib/testsuite/index.js Show resolved Hide resolved
@beatfactor
Copy link
Member

is this occurring only when in debug mode?

@swrdfish
Copy link
Member

yes the inspector is enabled only in debug mode.

vaibhavsingh97
vaibhavsingh97 approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had suggested a small refactor earlier, but it's totally up to you if you'd like to skip it.

lib/testsuite/index.js Outdated Show resolved Hide resolved
@AutomatedTester AutomatedTester merged commit 97035bc into nightwatchjs:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrdfish swrdfish swrdfish left review comments

@beatfactor beatfactor beatfactor approved these changes

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

@gravityvi gravityvi Awaiting requested review from gravityvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshit-bs @beatfactor @swrdfish @vaibhavsingh97 @AutomatedTester