-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #4028 fix : added fallback for clearValue command #4035
Merged
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
429283b
added fallback for clearValue command
FireNdIce3 3aebc28
changed double quotes to single quotes
FireNdIce3 e2e5535
added try catch block and minor changes
FireNdIce3 cdea3c6
added test cases and minor changes
FireNdIce3 ce47563
fixed formatting issues
FireNdIce3 0abbcf7
minor changes
FireNdIce3 ac53b94
test changes
FireNdIce3 6cbdecb
updated test case
FireNdIce3 92e43c0
fixed linting issues
FireNdIce3 4a1da9a
fixed formatting
FireNdIce3 8621aef
fixed formatting in testClearValue
FireNdIce3 a0514b7
updated test
FireNdIce3 d0a3e34
formatting fix
FireNdIce3 f060984
Merge branch 'main' of https://github.com/nightwatchjs/nightwatch int…
garg3133 851e5b1
Fix tests.
garg3133 9ae0939
Fix failing tests.
garg3133 01a95d0
Add tests to new Element API clear command.
garg3133 adc0d41
Add fallback to setValue command as well.
garg3133 55163cc
Add test for setValue command.
garg3133 dbff89a
Fix failing test.
garg3133 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you calling
.sendKeys()
command directly? We just want to call.clearValue
command from outside and then we want to test if the internalelement.sendKeys()
(which you specified in method-mappings.js file) was called or not if theelement.getProperty('value')
command still returns some value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @garg3133 ,
for some reason, the post request was not being sent when I tried checking the logs
So I looked into the codebase to see how keys were being sent in a test and I saw this method
I tried doing it by using .sendKeys() and it worked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still working on this issue ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I am working on this. had been sick that's why the delay
apologies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just wanted to make sure that this is all still being worked on. I could land an eye if you need. (not sure that I can be of a great help but I can still try 😬)