fix:isVisible command added to the new API #4052
Conversation
|
|
|
Running CI, will review when tests are complete. If there are failures please look into them |
| * export default { | ||
| * demoTest(browser: NightwatchAPI): void { | ||
| * const result = browser.element('#main').isVisible(); | ||
| * .assert.equals(true); | ||
| * }, | ||
| * | ||
| * async demoTestAsync(browser: NightwatchAPI): Promise<void> { | ||
| * const result = await browser.element('#main').isVisible(); | ||
| * browser.assert.equal(result,true) | ||
| * } | ||
| * } |
There was a problem hiding this comment.
This example won't work (due to an obvious mistake). You should always try to run the examples yourself before putting them here.
| it('test .element().isVisible() Visible', async function() { | ||
| MockServer.addMock({ | ||
| url: '/session/13521-10219-202/element/0/Visible', | ||
| method: 'GET', | ||
| response: JSON.stringify({ | ||
| value: true | ||
| }) | ||
| }, true); | ||
|
|
||
| this.client.api.element('#search').isVisible(function (result) { | ||
| this.assert.equal(result.value, true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
These tests are wrong:
- '/session/13521-10219-202/element/0/Visible' endpoint does not exist.
isVisible()command does not accept a callback.
The only reason this test is passing is because no assertion is being run in actual, because all the assertions are present in the callback which is never called.
It seems to me that you've just blindly copied the tests from some other PR and didn't care to understand what it is doing or ask questions.
|
Closing this since there has been no activity on this and moreover the code seems to be copied from some other PR. |
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
fix - #4037
features/my-new-featureorissue/123-my-bugfix);