-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing isVisible
command in new Element API
#4037
Comments
Can I take this issue? |
hey @garg3133 can I get assigned for this issue? |
Hey @garg3133 , I can take this issue and fix it up. Can you assign this to me? |
@garg3133 Hey, I would like to work on it can you assign it to me... |
@garg3133 hello, I'm new to open source and eager to contribute. Could you please assign this issue to me? |
Hey, I would like to work on this issue. Could you assign it to me? |
Can I work on this issue? |
Fixed issue nightwatchjs#4037
Could you please review my PR? |
@Vaaruna2709 I think you have raised PR to the main branch of your own fork. |
Hey, @garg3133 , I would like to work on it can you assign it to me... |
Hey @garg3133, I would like to work on this can you assign me |
@garg3133 I have worked on this issue and tested the isVisible and isDisplayed Commands. 2024-02-26.17-28-35.mp4Please assign me this issue. |
Hi @garg3133 , I've identified that the isVisible command is missing in the new Element API, causing errors when users try to use it. To address this, I've proposed a solution by creating a new file named isVisible.js, which includes the missing command and introduces a helpful alias isDisplayed. The implementation follows the existing commands' structure, including clear JSDoc. Could I take on this issue to contribute to the fix? Thanks! |
@garg3133 I've taken a look at issue and would like to contribute by solving it. It seems like a good issue to start off with. Looking forward to your guidance. |
Hey @garg3133 can i take this issue? Will like to contriburte,please assign it to me. |
Fixed in #4039 |
Description of the bug/issue
The
isVisible
command is currently missing from the new Element API. To support this command, a new file namedisVisible.js
needs to be added insidelib/api/web-element/commands
directory, whose content should be similar to theget*
command files present in the same directory.The argument passed to
this.runQueuedCommandScoped
in these files is the name of the corresponding method to be called from thelib/transport/selenium-webdriver/method-mappings.js
file.Moreover, we'd also need to have
isDisplayed()
as an alias to theisVisible()
command.Steps to reproduce
Go to any test file and try to add
const result = await browser.element('<selector>').isVisible()
and then run the test. This would result in an error right now, while if you replaceisVisible()
withgetText()
, it should work fine.After adding the command implementation, the
.isVisible()
command should work fine and return aboolean
promise.TODO
isDisplayed
as an alias toisVisible()
commandThe text was updated successfully, but these errors were encountered: